fix(LICENSE): derive Libraries folder from MIT-licensed code by rozele · Pull Request #1659 · microsoft/react-native-windows

rozele · 2018-02-21T14:01:10Z

react-native recently moved to the MIT license. In order to remove the BSD+Patents licensing from react-native-windows, we have to re-derive the source code we copied from react-native from the latest source code. This change re-derives the source code in the Libraries folder.

rozele · 2018-02-21T14:04:05Z

Libraries/Components/PasswordBoxWindows/PasswordBoxWindows.windows.js

- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
 *


Detailed review needed. #Closed

RNTester working correctly.

In reply to: 169645133 [](ancestors = 169645133)

rozele · 2018-02-21T14:09:42Z

Libraries/Components/ScrollView/ScrollView.windows.js

 /**
 * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
 *


Detailed review needed. #Closed

RNTester still working properly.

In reply to: 169646847 [](ancestors = 169646847)

rozele · 2018-02-21T14:13:28Z

Libraries/Components/TextInput/TextInput.windows.js

 /**
 * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
 *


Detailed review needed. #Closed

Had to revert to enable auto-grow. Work remains to ensure TextInput can grow correctly.

In reply to: 169647991 [](ancestors = 169647991)

rozele · 2018-02-21T14:14:14Z

Libraries/Components/View/ViewPropTypes.windows.js

- * of patent rights can be found in the PATENTS file in the same directory.
- *
- * @providesModule ViewPropTypes
- * @flow


Confirm e.g. manipulationModes still work. #Closed

SwipeableListView in RNTester still working.

In reply to: 169648288 [](ancestors = 169648288)

rozele · 2018-02-21T14:16:14Z

Libraries/Components/WebView/WebView.windows.js

 /**
 * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
 *


Detailed review needed. #Closed

The only difference between this and upstream is indexedDBEnabled. I'm not sure we need this feature.

In reply to: 169648900 [](ancestors = 169648900)

All features in RNTester are working.

In reply to: 169956593 [](ancestors = 169956593,169648900)

rozele · 2018-02-21T14:16:42Z

Libraries/Image/Image.windows.js

- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
 *


Detailed review needed. #Closed

RNTester still working.

In reply to: 169649082 [](ancestors = 169649082)

rozele · 2018-02-21T14:16:51Z

Libraries/Network/NetInfo.windows.js

- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
 *


Detailed review needed. #Closed

Old version still working, more work to do to subscribe to the connectionChange event.

In reply to: 169649181 [](ancestors = 169649181)

rozele · 2018-02-21T14:17:19Z

Libraries/Network/RCTNetworking.windows.js

-    callback: (requestId: number) => any
+    callback: (requestId: number) => any,
+    withCredentials: boolean
  ) {


Remove for now, but we should add this. #Closed

RNTester working once removed.

In reply to: 169649317 [](ancestors = 169649317)

rozele · 2018-02-21T14:17:53Z

Libraries/Text/Text.windows.js

@@ -1,576 +0,0 @@
-/**
- * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.


Ensure Text still works. #Closed

Text still works as expected.

In reply to: 169649482 [](ancestors = 169649482)

rozele · 2018-02-21T14:19:17Z

Libraries/WebSocket/WebSocket.windows.js

 /**
 * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
 *


Detailed review needed. #Closed

RNTester WebSocket example still working (tested both binary and text send/receive)

In reply to: 169649951 [](ancestors = 169649951)

rozele · 2018-02-21T19:44:40Z

Libraries/WebSocket/WebSocket.windows.js

 /**
 * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
 *


Check if #253 is now fixed. #Closed

No - still work to do here to support all kinds of headers.

In reply to: 169755860 [](ancestors = 169755860)

rozele · 2018-02-22T13:29:32Z

Add UNSAFE to all deprecated React lifecycle events.

rozele · 2018-02-22T13:34:33Z

Track issues for all new features to catch up with. #Closed

rozele · 2018-02-22T19:56:54Z

Libraries/Components/Picker/PickerWindows.js

- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
 *


Verify if this fixes #1613 (and removes the need for #1639)

react-native recently moved to the MIT license. In order to remove the BSD+Patents licensing from react-native-windows, we have to re-derive the source code we copied from react-native from the latest source code. This change re-derives the source code in the Libraries folder.

Many of these files never existed in react-native. In most cases, the copyright header was just copied from other files. This was incorrect, the header should have originally reflected a Microsoft copyright. This commit fixes that, and also rebases copy-paste code against Facebook's latest MIT-licensed code.

…w MIT Updates the README and the LICENSE at the root folder to reflect that portions of the React Native Windows plugin derived from Facebook are copyright Facebook. Both derived and original contributions in React Native Windows are provided under the MIT license.

rozele commented Feb 21, 2018

View reviewed changes

rozele force-pushed the mit branch from 48cd96b to bf7ec56 Compare February 21, 2018 14:55

rozele commented Feb 21, 2018

View reviewed changes

rozele force-pushed the mit branch from bf7ec56 to c944f94 Compare February 22, 2018 18:22

rozele commented Feb 22, 2018

View reviewed changes

rozele force-pushed the mit branch 3 times, most recently from cec812e to cd7064c Compare March 1, 2018 11:12

rozele added 3 commits March 5, 2018 10:26

rozele force-pushed the mit branch from cd7064c to 45d572b Compare March 5, 2018 15:26

rozele merged commit b8135c5 into microsoft:master Mar 6, 2018

rozele deleted the mit branch March 6, 2018 13:19

Conversation

rozele commented Feb 21, 2018

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozele commented Feb 22, 2018

Uh oh!

rozele commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele Feb 21, 2018 •

edited

Loading

rozele commented Feb 22, 2018 •

edited

Loading