[Fabric] Fixing Clipped Property for Modal Component #15176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protikbiswas100
approved these changes
Sep 26, 2025
Nitin-100
approved these changes
Sep 26, 2025
iamAbhi-916
reviewed
Sep 26, 2025
| // Component appears clipped, but check if it's modal content | ||
| // Modal content may appear clipped due to lack of parent relationships | ||
| // but should still be considered visible if it's in its own window | ||
| try { |
There was a problem hiding this comment.
this property (clip state) will be queried very frequently like UI nav, refresh, accessibility calls. we shouldn't use try catch here it will be perf hit.
There was a problem hiding this comment.
Will remove it then.
vineethkuttan
added a commit
that referenced
this pull request
Sep 29, 2025
* Fixing Clipped Property for Modal Component * Yarn Change * Removed try catch.
vineethkuttan
added a commit
that referenced
this pull request
Oct 8, 2025
* [Fabric] Fixing Clipped Property for Modal Component (#15176) * Fixing Clipped Property for Modal Component * Yarn Change * Removed try catch. * Review Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing UIA Clipping property for Modal Component.
Type of Change
Erase all that don't apply.
Why
Will fix the UIA clipping state of Modal Component.
Resolves [microsoft/react-native-gallery/issues/650]
What
Clipped
Screenshots
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: yes
UIA Clipping property for Modal Component is fixed.
Microsoft Reviewers: Open in CodeFlow