[Fabric] Fix for Text and TextInput focus issue with screen readers #15088
+37
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineethkuttan
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes accessibility issues with Text and TextInput components in React Native Windows Fabric architecture, specifically addressing focus problems when using screen readers. The changes implement proper UI Automation (UIA) text pattern provider methods that were previously stubbed out as no-ops.
Key changes:
- Implements proper
CloneandComparemethods for TextRangeProvider to support screen reader navigation - Fixes return value handling in
GetAttributeValuemethod for text styling attributes - Adds null pointer validation across multiple methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CompositionTextRangeProvider.cpp | Implements UIA TextRangeProvider methods for screen reader compatibility and fixes attribute value return handling |
| change/react-native-windows-4046d3e2-cc00-459e-b62d-4489b3ef14d1.json | Adds changelog entry for the accessibility fix |
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
Show resolved
Hide resolved
acoates-ms
approved these changes
Aug 29, 2025
iamAbhi-916
approved these changes
Sep 1, 2025
anupriya13
approved these changes
Sep 1, 2025
HariniMalothu17
approved these changes
Sep 1, 2025
vineethkuttan
added a commit
that referenced
this pull request
Sep 2, 2025
…15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file
vineethkuttan
added a commit
that referenced
this pull request
Sep 2, 2025
…#15105) * [Fabric] Implement announceForAccessibility in AccessibilityInfo Module (#14995) * Implementation of announce for accessibility for fabric * Build fix * Removed Debug Message * Yarn Change * Copilot Suggestions * Review Changes * Storing the weak_ref island in property to avoid circular ref * Adding deleted Change Files * [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0 * [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file
protikbiswas100
pushed a commit
to protikbiswas100/react-native-windows
that referenced
this pull request
Sep 3, 2025
…icrosoft#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Sep 11, 2025
…icrosoft#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file
acoates-ms
added a commit
that referenced
this pull request
Sep 19, 2025
* Pointer events (#14713) * PointerEvent fixes * Change files * format * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Fabric : Added support for selectionColor in TextInput component (#14743) * Added support for selectionColor for textInput * yarn fix and format * Change files * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <kvineeth@microsoft.com> * Text : Added EllipsizeMode for tail and clip alignment (#14660) * updated ellipsis to respect tail and clip behaviour , for head , middle follow defaulty tail behaviour * patched updateTextAlignment method * Change files * pathced branch , lint fix , lint format * updated snapshots * added layout changes to TextLayoutManager * lint fix and format * updated snapshots * updated snapshot Pressable component * updated to remove extra text_layout null check * removed comments * format and lint:fix * [Fabric] Implement onContentSizeChange in TextInput (#14785) * Fix : adjustsFontSizeToFit just redrawing won't recalculate the layout (#14813) * updated adjustsFontSizeToFit textlayout to nullptr * Change files * [Fabric] Implement autoFocus property for TextInput for fabric (#14816) * Added fix for AutoFocus * Change files --------- Co-authored-by: Harini Malothu <hmalothu@microsoft.com> * [Fabric] Implementation of accessibilityDescription (#14818) * Initial Commit for accessibilityDescription * Change files * Format Changes * Updating Snapshot * [Fabric] Implement maxFontSizeMultiplier in Text Input (#14639) * [Fabric] Fix for updating accessibility value in UIA (#14858) * Changes for updating accessibilityValue prop * Change files * TextInput should capture mouse on mouse down (#14983) * TextInput should capture mouse on mouse down * Change files * format * [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0 * [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332) * Partial Implementation * Add More Implementation * More Implementation * More Implementation * Add Support for Bounding Rectangles * Complete Initial Implementation * Change files * Code Cleanup * Code Cleanup * Update Snapshots + Code Cleanup * Update Snapshots * Address Feedback * Address Feedback * Update Snapshots * Fix Tests --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file * Screen reader fails to announce the expand/collapse state of the navigation button (#15106) * adding UIA event handler changes for navigator * Change files * adding ViewComponent chnages for accessibility * removing unnecessary change file * Remove vnext/fmt/packages.lock.json --------- Co-authored-by: Protik Biswas <protikbiswas100@microsoft.com> * fix * fix * Upgrade dotnet version * Change files * bump sdk * bump node * fix * fix * Change files * fix * fix * test * fix * fix * update snapshots * snapshot * snapshot * measureLines * fix * snapshot --------- Co-authored-by: Anupriya Verma <54227869+anupriya13@users.noreply.github.com> Co-authored-by: Abhijeet Jha <74712637+iamAbhi-916@users.noreply.github.com> Co-authored-by: Vineeth <66076509+vineethkuttan@users.noreply.github.com> Co-authored-by: Vineeth K <kvineeth@microsoft.com> Co-authored-by: Harini Malothu <harinimalothu17@gmail.com> Co-authored-by: Harini Malothu <hmalothu@microsoft.com> Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: Protik Biswas <219775028+protikbiswas100@users.noreply.github.com> Co-authored-by: Protik Biswas <protikbiswas100@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for Text and TextInput focus issue with screen readers
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
This changes will make screen readers to access Text and Text Input Component.
Resolves [#14499 ,#15045,microsoft/react-native-gallery/issues/589]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Implemented to methods for TextRangeProvider and some bug fix.
Screenshots
Before:
UnableToMove.mp4
After:
GotFoxus.mp4
Testing
Tested in Playground
Changelog
Should this change be included in the release notes: yes
Add a brief summary of the change to use in the release notes for the next release.
Fix for Text and TextInput focus issue with screen readers in Fabric
Microsoft Reviewers: Open in CodeFlow