Add accessibilityValue support to Button component #14903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for
accessibilityValue
prop in the React Native Windows Button component, enabling proper propagation of accessibility values from JavaScript to the native C++ layer.Problem
The Button component in
Button.windows.js
was missing support for theaccessibilityValue
prop and relatedaria-value*
props, which prevented accessibility values from being passed through to the underlying TouchableHighlight component. This was identified in the existing ButtonExample whereaccessibilityValue={{Text: 'Submit Application'}}
was being used but not actually supported by the component.Changes Made
1. Type Support
AccessibilityValue
import from./View/ViewAccessibility
accessibilityValue?: ?AccessibilityValue
toButtonProps
type definitionaria-valuemax
,aria-valuemin
,aria-valuenow
, andaria-valuetext
props with proper typing2. Component Logic
accessibilityValue
andaria-value*
props in component destructuring_accessibilityValue
computation logic that mirrors the View component implementationaria-value*
props take precedence overaccessibilityValue
object properties3. Prop Propagation
accessibilityValue={_accessibilityValue}
to TouchableHighlight in both Windows and non-Windows code paths4. Example Updates
text
instead ofText
)aria-value*
props usage alongsideaccessibilityValue
Usage Examples
After this change, Button components now support both forms of accessibility value specification:
Testing
Fixes #14902.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.