Skip to content

Fabric : Added support for selectionColor in TextInput component #14743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Fabric : Added support for selectionColor in TextInput component #14743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
501edbf
Added support for selectionColor for textInput
iamAbhi-916 Jun 6, 2025
2b641ec
yarn fix and format
iamAbhi-916 Jun 6, 2025
36dc841
Change files
iamAbhi-916 Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-b47cf142-681b-41f5-8ac6-d07b04f55165.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Added support for selectionColor for textInput",
"packageName": "react-native-windows",
"email": "74712637+iamAbhi-916@users.noreply.github.com",
"dependentChangeType": "none"
}
33 changes: 23 additions & 10 deletions vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,20 +320,30 @@ struct CompTextHost : public winrt::implements<CompTextHost, ITextHost> {
return (*m_outer->windowsTextInputProps().textAttributes.foregroundColor).AsColorRefNoAlpha();
// cr = 0x000000FF;
break;

case COLOR_WINDOW:
if (m_outer->viewProps()->backgroundColor)
return (*m_outer->viewProps()->backgroundColor).AsColorRefNoAlpha();
break;
// case COLOR_HIGHLIGHT:
// cr = RGB(0, 0, 255);
// cr = 0x0000ffFF;
// break;

// case COLOR_HIGHLIGHTTEXT:
// cr = RGB(255, 0, 0);
// cr = 0xFFFFFFFF;
// break;
case COLOR_HIGHLIGHT:
if (m_outer->windowsTextInputProps().selectionColor)
return (*m_outer->windowsTextInputProps().selectionColor).AsColorRefNoAlpha();
break;

case COLOR_HIGHLIGHTTEXT:
// For selected text color, we use the same color as the selection background
// or the text color if selection color is not specified
if (m_outer->windowsTextInputProps().selectionColor) {
// Calculate appropriate text color based on selection background
auto selectionColor = (*m_outer->windowsTextInputProps().selectionColor).AsColorRefNoAlpha();
// Use white text for dark selection, black text for light selection
int r = GetRValue(selectionColor);
int g = GetGValue(selectionColor);
int b = GetBValue(selectionColor);
int brightness = (r * 299 + g * 587 + b * 114) / 1000;
return brightness > 125 ? RGB(0, 0, 0) : RGB(255, 255, 255);
}
break;

// case COLOR_GRAYTEXT:
// cr = RGB(128, 128, 128);
Expand Down Expand Up @@ -1126,11 +1136,14 @@ void WindowsTextInputComponentView::updateProps(
bool effectiveSpellCheck = newTextInputProps.spellCheck || newTextInputProps.autoCorrect;
updateSpellCheck(effectiveSpellCheck);
}

if (!oldProps || oldTextInputProps.autoCorrect != newTextInputProps.autoCorrect) {
updateAutoCorrect(newTextInputProps.autoCorrect);
}

if (oldTextInputProps.selectionColor != newTextInputProps.selectionColor) {
m_needsRedraw = true;
}

UpdatePropertyBits();
}

Expand Down