Add font attributes to testing E2E #14584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses a bug fix by introducing additional font attributes for enhanced E2E test coverage. The changes include updating attribute handling in CompositionTextRangeProvider and adding new test utility functions and attribute retrieval logic in RNTesterApp-Fabric.
- Updated CompositionTextRangeProvider to use VT_INT and assign font cap style values.
- Added overloaded InsertNumberValueIfNotDefault functions and extended DumpUIAPatternInfo to retrieve and record various font-related attributes.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp | Changed cap style attribute handling from returning values to assigning them to pRetVal, and updated type from VT_I4 to VT_INT. |
| packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp | Introduced two overloaded InsertNumberValueIfNotDefault functions and extended DumpUIAPatternInfo to include fetching of additional font attributes. |
Files not reviewed (1)
- change/react-native-windows-abe3b81a-02be-4c81-86e1-40bbf5d69332.json: Language not supported
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
Outdated
Show resolved
Hide resolved
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Show resolved
Hide resolved
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
Outdated
Show resolved
Hide resolved
vineethkuttan
force-pushed
the
addFontAttributesToE2E
branch
from
cee1324 to
da39d3e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Add E2E test cases for PR #14332
Microsoft Reviewers: Open in CodeFlow