[0.77] Backport fixes for Modal #14490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14256) * Rework modal implementation to use public APIs * shutdown fix * Change files * format * remove dead code * format * fixes * fix * UIA tree for root component should be kept distinct from main UIA tree * input offset fix for sub rootviews * Split modal into two componentview's so that we dont have multiple roots in our componentview tree * format * Ensure rootview removes itself from the island, before a new one adds itself on instance reload * defork some modal test pages * remove override
…microsoft#14315) * Allow portals to have independent layout constraints and scale factor * format * change files * fix
Yajur-Grover
changed the title
This was
linked to
issues
Apr 7, 2025
|
Looking at 0.78-stable, it looks like that is missing #14315 too! We will want to make sure we match 0.77 and 0.78 so we aren't having regression between the versions |
* fix modal height * Change files * reverse change * add override
TatianaKapos
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring in the following changes to fix issues with Modal on 0.77: #14315, #14256, #14343
Type of Change
Why
Resolves #14485
Resolves #14486
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow