Skip to content

Fix react devtools hitting an assert on launch #14320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Fix react devtools hitting an assert on launch #14320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bd32a0
ignore unsupported methods
TatianaKapos Jan 29, 2025
a1e0d42
delete Super::DispatchCommand call
TatianaKapos Jan 29, 2025
bb1c8f8
Change files
TatianaKapos Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-fb01ddc4-cef6-477e-b91d-7583eeb458b1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix react devtools hitting an assert on launch",
"packageName": "react-native-windows",
"email": "tatianakapos@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Views/DebuggingOverlayViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ void DebuggingOverlayViewManager::DispatchCommand(
// There is little point in attempting to implement these commands until then.
return;
}
Super::DispatchCommand(viewToUpdate, commandId, std::move(commandArgs));
}

} // namespace Microsoft::ReactNative