Skip to content

[0.74] std::aligned_storage is deprecated #14255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[0.74] std::aligned_storage is deprecated #14255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4359d18
std::aligned_storage is deprecated (#14253)
tiagomacarios Jan 8, 2025
4ce5196
update change file
acoates-ms Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-94cad441-d079-4e22-bfcc-f2beb900bad1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "std::aligned_storage is deprecated",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
8 changes: 6 additions & 2 deletions vnext/Microsoft.ReactNative.Cxx/JSI/JsiAbiApi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,9 @@ struct JsiAbiRuntime : facebook::jsi::Runtime {
~ValueRef() noexcept;
operator facebook::jsi::Value const &() const noexcept;

using StoreType = std::aligned_storage_t<sizeof(DataPointerValue)>;
struct alignas(std::max_align_t) StoreType {
std::byte buffer[sizeof(DataPointerValue)];
};
static void InitValueRef(JsiValueRef const &data, facebook::jsi::Value *value, StoreType *store) noexcept;

private:
Expand All @@ -307,7 +309,9 @@ struct JsiAbiRuntime : facebook::jsi::Runtime {
~PropNameIDRef() noexcept;
operator facebook::jsi::PropNameID const &() const noexcept;

using StoreType = std::aligned_storage_t<sizeof(DataPointerValue)>;
struct alignas(std::max_align_t) StoreType {
std::byte buffer[sizeof(DataPointerValue)];
};

private:
StoreType m_pointerStore{};
Expand Down
Loading