Skip to content

Conversation

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Oct 3, 2024

Description

Removes the packages.lock.json and packages.fabric.lock.json files from our published NPM packages, as customers who choose to build M.RN themselves don't necessarily choose the same dependencies as us (such as SourceLink).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

See above.

Resolves #13914

What

Added filters to the NPM package.json files to exclude these lock files.

Screenshots

N/A

Testing

Verified with npm pack that new packages do not contain these files.

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

…13916)

## Description

Removes the `packages.lock.json` and `packages.fabric.lock.json` files from our published NPM packages, as customers who choose to build M.RN themselves don't necessarily choose the same dependencies as us (such as SourceLink).

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
See above.

Resolves microsoft#13914

### What
Added filters to the NPM `package.json` files to exclude these lock files.

## Screenshots
N/A

## Testing
Verified with `npm pack` that new packages do not contain these files.

## Changelog
Should this change be included in the release notes: _no_
@jonthysell jonthysell requested a review from a team as a code owner October 3, 2024 21:46
@jonthysell jonthysell merged commit 25a9ed1 into microsoft:0.76-stable Oct 4, 2024
101 checks passed
@jonthysell jonthysell deleted the removelocks76 branch October 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants