-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add new architecture cpp-app template for init-windows
#12172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the starting template for a purely "new architecture" RNW app, based on our current progress in implementing turbo modules and fabric.
marlenecota
approved these changes
Sep 23, 2023
chrisglein
approved these changes
Sep 25, 2023
cpp-app template for init-windowscpp-app template for init-windows
TatianaKapos
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: App Template
Area: CLI
Area: Fabric
Support Facebook Fabric
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the starting template for a purely "new architecture" RNW app, based on our current progress in implementing turbo modules and fabric. It also makes some supporting changes such as making sure
run-windowsstill works and adding new non-UWP external property sheets.Type of Change
Why
This gives us the ability to start experimenting with fabric apps outside of the specialized versions in our repo.
Closes #11908
Closes #12171
What
Created a new generalized app template based on the
e2e-test-app-fabrictest app and the first minimal sample RNW fabric app here: https://github.com/chiaramooney/sample-fabric/.This template can be used to initialize a new RNW app using all new architecture features, on an existing react-native project.
Once checked in, folks should be able to try this out with some variant of:
Metro should start as well as launch the packaged version of your app.
Screenshots
Testing
I created a new project (using my linked local RNW repo) using the following:
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow