Implements backgroundColor for Fabric's TextInput #12079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies a fill rect to the composition visual Fixes microsoft#11763
microsoft-github-policy-service
bot
added
Area: Fabric
acoates-ms
reviewed
Aug 25, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Aug 25, 2023
Applies a fill rect to the composition visual Fixes microsoft#11763
chrisglein
force-pushed
the
textBackground
branch
from
f2fe544 to
925ccfc
Compare
acoates-ms
reviewed
Aug 25, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Aug 25, 2023
chrisglein
added
the
AutoMerge
acoates-ms
approved these changes
Aug 28, 2023
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fabric's
TextInputdidn't apply thebackgroundColorset in the style.Type of Change
Why
Fixing this applies a helpful solution to the removal of the default background chrome from
TextInput(previously applied by XAMLTextBox.Resolves #11763
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
And in Artificial Chat:
Testing
Tested in ArtificialChat by adding to the main chat box.
Tested in Playground with the existing TextInput page (and on 2 different machines/monitors with different DPIs, because I didn't apply the scale the first time 😅)
Changelog
Should this change be included in the release notes: Yes
Implemented
backgroundColorfor Fabric'sTextInputMicrosoft Reviewers: Open in CodeFlow