Skip to content

Conversation

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Jul 26, 2023

Description

This PR deprecates the Microsoft.ReactNative.WindowsAppSDK project.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Why

These projects/templates were early, experimental work for a future of RNW apps being WinAppSDK-based. Since we're not going in that direction, we shouldn't persist allowing projects to be created using it.

Resolves #11744

What

  • Deleting the Microsoft.ReactNative.WindowsAppSDK project files
  • Removing all jobs/tasks related to building/testing/publishing Microsoft.ReactNative.WindowsAppSDK
  • Removes the cs-app-WinAppSDK app template and specific new project creation code

Note: The existing UseWinUI3 msbuild property and corresponding USE_WINUI3 build flags are intentionally not touched in this PR, to maintain the minimum support for some customers.

Screenshots

N/A

Testing

N/A

Changelog

Should this change be included in the release notes: Yes

The Microsoft.ReactNative.WindowsAppSDK experimental project has been deprecated and will no longer be supported.

Microsoft Reviewers: codeflow:open?pullrequest=#11945

This PR deprecates the `Microsoft.ReactNative.WindowsAppSDK` project by:

* Deleting the `Microsoft.ReactNative.WindowsAppSDK` project files
* Removing all jobs/tasks related to building/testing/publishing `Microsoft.ReactNative.WindowsAppSDK`
* Removes the `cs-app-WinAppSDK` app template and project creation code
@jonthysell jonthysell added the Breaking Change This PR will break existing apps and should be part of the known breaking changes for the release label Jul 26, 2023
@jonthysell jonthysell changed the title [WIP] Deprecate Microsoft.ReactNative.WindowsAppSDK project Deprecate Microsoft.ReactNative.WindowsAppSDK project Jul 27, 2023
@jonthysell jonthysell marked this pull request as ready for review July 27, 2023 18:36
@jonthysell jonthysell requested review from a team as code owners July 27, 2023 18:36
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonthysell jonthysell merged commit 7212312 into microsoft:main Aug 7, 2023
@jonthysell jonthysell deleted the removewinappsdk branch August 7, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Infrastructure Breaking Change This PR will break existing apps and should be part of the known breaking changes for the release Platform: WinAppSDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate the WindowsAppSDK app template and projects

2 participants