Adds simple animated fabric activityIndicator #11537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaKapos
changed the title
TatianaKapos
changed the title
TatianaKapos
changed the title
acoates-ms
requested changes
May 1, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/ActivityIndicatorComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ActivityIndicatorComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ActivityIndicatorComponentView.h
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ActivityIndicatorComponentView.h
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
acoates-ms
approved these changes
May 2, 2023
156 tasks
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in a simple animated activityIndicator to Fabric. More work is needed to bring it to parity to the previous XAML ActivityIndicator such as adjusting the timing of the animation and size.
Type of Change
Why
#11162
What
Created an ActivityIndicatorVisual in CompostionContextHelper.cpp and set the visual in ActivityIndicatorComponentView
Screenshots
Testing
Tested Locally