Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NativeModulesWindows.md #1089

Merged
merged 2 commits into from
May 31, 2017
Merged

Update NativeModulesWindows.md #1089

merged 2 commits into from
May 31, 2017

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Apr 12, 2017

Revise the document to use NativeEventEmitter, as RCTDeviceEventEmitter in JavaScript is deprecated.

@msftclas
Copy link

@Kudo,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

Codecov Report

Merging #1089 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   31.53%   31.53%           
=======================================
  Files         253      253           
  Lines       18037    18037           
  Branches     1519     1519           
=======================================
  Hits         5688     5688           
  Misses      12192    12192           
  Partials      157      157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd864b7...ba93398. Read the comment docs.

@matthargett matthargett merged commit 5f94f29 into microsoft:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants