Skip to content

Remove all uses of findNodeHandle #4183

Open

Description

@kmelmon

tags aren't supported by Fabric. The main function that deals with tags is findNodeHandle(). Facebook is replacing all tags with instances. We need to do the same in our overrides.

There are multiple places we're doing this:
Libraries\Components\Flyout\Flyout.windows.tsx:42: const newtarget: number | null = findNodeHandle(nextProps.target as
Libraries\Components\Popup\Popup.windows.tsx:42: const newTarget: number | null = findNodeHandle(nextProps.target as
Libraries\Components\ScrollView\ScrollView.windows.js:752: return ReactNative.findNodeHandle(this._scrollViewRef);
Libraries\Components\ScrollView\ScrollView.windows.js:756: return ReactNative.findNodeHandle(this._innerViewRef);
Libraries\Components\TextInput\TextInput.windows.js:825: ReactNative.findNodeHandle(this._inputRef)
Libraries\Components\TextInput\TextInput.windows.js:837: const tag = ReactNative.findNodeHandle(this._inputRef);
Libraries\Components\TextInput\TextInput.windows.js:853: const tag = ReactNative.findNodeHandle(this._inputRef);
Libraries\Lists\VirtualizedList.windows.js:444: return ReactNative.findNodeHandle(this._scrollRef);

Activity

  1. ghost added
    Needs: Triage 🔍New issue that needs to be reviewed by the issue management team (label applied by bot)
    on Feb 25, 2020
  2. removed
    Needs: Triage 🔍New issue that needs to be reviewed by the issue management team (label applied by bot)
    on Feb 27, 2020
  3. ghost added
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Sep 16, 2020
  4. added and removed
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Sep 25, 2020
  5. added
    New ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
    on Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: FabricSupport Facebook FabricCode CleanupNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricWorkstream: Component ParityClose the parity gap between RNW and RN for core RN components and their supporting APIs.enhancement

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions