-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Area: FabricSupport Facebook FabricSupport Facebook FabricArea: LayoutArea: ModalNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricWorkstream: Component ParityClose the parity gap between RNW and RN for core RN components and their supporting APIs.Close the parity gap between RNW and RN for core RN components and their supporting APIs.bug
Milestone
Description
Problem Description
Modal works with a View that sets a height/width but gets funky with padding/flex styling. Need to figure out a better way to implement layout (this may involve splitting RNW Island into two different classes if layout diverges too much).
Currently Modal is getting the overflow of it's children and setting that to it's height/width. I'm not sure why add padding/flex to a child would change this overflow.
Steps To Reproduce
- Remove commented out lines in ModalPresentation.windows.js and ModalOnShow.windows.js
- Run Modal Example in playground-composition.cpp rntester
- Modal won't be the correct layout.
Expected Results
Modal has the correct layout
Metadata
Metadata
Assignees
Labels
Area: FabricSupport Facebook FabricSupport Facebook FabricArea: LayoutArea: ModalNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricWorkstream: Component ParityClose the parity gap between RNW and RN for core RN components and their supporting APIs.Close the parity gap between RNW and RN for core RN components and their supporting APIs.bug
Type
Projects
Status
Done