Skip to content

[Modal] Layout doesn't work with flex/padding styling #14070

@TatianaKapos

Description

@TatianaKapos

Problem Description

Modal works with a View that sets a height/width but gets funky with padding/flex styling. Need to figure out a better way to implement layout (this may involve splitting RNW Island into two different classes if layout diverges too much).

Currently Modal is getting the overflow of it's children and setting that to it's height/width. I'm not sure why add padding/flex to a child would change this overflow.

Steps To Reproduce

  1. Remove commented out lines in ModalPresentation.windows.js and ModalOnShow.windows.js
  2. Run Modal Example in playground-composition.cpp rntester
  3. Modal won't be the correct layout.

Expected Results

Modal has the correct layout

Metadata

Metadata

Assignees

Labels

Area: FabricSupport Facebook FabricArea: LayoutArea: ModalNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricWorkstream: Component ParityClose the parity gap between RNW and RN for core RN components and their supporting APIs.bug

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions