Fix unintended fallthrough causing duplicate WM_CHAR handling in Fabric TextInput (#11469)

chrisglein · web-flow · commit ca37eb7b34f8 · 2023-04-11T18:02:48.000-07:00
* Fix unintended fallthrough
This was causing a WM_CHAR to fallthrough to WM_KEYDOWN
and produce a duplicate `sendMessage`
diff --git a/change/react-native-windows-298c0d56-3472-45c2-a2e6-8d139481f19c.json b/change/react-native-windows-298c0d56-3472-45c2-a2e6-8d139481f19c.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Fix unintended fallthrough This was causing a WM_CHAR to fallthrough to WM_KEYDOWN and produce a duplicate `sendMessage`",
+  "packageName": "react-native-windows",
+  "email": "26607885+chrisglein@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
diff --git a/vnext/Microsoft.ReactNative/Fabric/Composition/CompositionEventHandler.cpp b/vnext/Microsoft.ReactNative/Fabric/Composition/CompositionEventHandler.cpp
@@ -164,6 +164,7 @@ int64_t CompositionEventHandler::SendMessage(uint32_t msg, uint64_t wParam, int6
         if (result)
           return result;
       }
+      break;
     }
     case WM_KEYDOWN:
     case WM_KEYUP:

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ int64_t CompositionEventHandler::SendMessage(uint32_t msg, uint64_t wParam, int6`
`164`	`164`	`if (result)`
`165`	`165`	`return result;`
`166`	`166`	`}`
	`167`	`+ break;`
`167`	`168`	`}`
`168`	`169`	`case WM_KEYDOWN:`
`169`	`170`	`case WM_KEYUP:`