Fix unintended fallthrough causing duplicate WM_CHAR handling in Fabric TextInput #11469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a WM_CHAR to fallthrough to WM_KEYDOWN and produce a duplicate `sendMessage`
microsoft-github-policy-service
bot
added
Area: Fabric
Contributor
|
Needs a change file. But looks good. |
acoates-ms
approved these changes
Apr 7, 2023
Member
|
can you turn on C26819 and make it an error? intended fallthroughs should use |
Member
Author
TatianaKapos
approved these changes
Apr 11, 2023
chrisglein
added
the
AutoMerge
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a WM_CHAR to fallthrough to WM_KEYDOWN and produce a duplicate
sendMessageDescription
Type of Change
Why
Resolves #11452
What
There was a switch case fallthrough happening from WM_CHAR to WM_KEYDOWN. The fix is to add a break statement.
Testing
Patched the source change into a Fabric app that was reproing the issue (AKA one with a
TextInput)Microsoft Reviewers: Open in CodeFlow