Skip to content

chore: swiftlint should not lint node_modules #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 5, 2025

Description

swiftlint should not lint node_modules:

% yarn lint:swift
Linting Swift files in current working directory
[...]
/~/node_modules/@react-native-community/template/template/ios/HelloWorld/AppDelegate.swift:8:135: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
/~/node_modules/@react-native-community/template/template/ios/HelloWorld/AppDelegate.swift:8:1: warning: Line Length Violation: Line should be 120 characters or less; currently it has 159 characters (line_length)
[...]
Done linting! Found 2 violations, 0 serious in 16 files.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from JasonVMo as a code owner May 5, 2025 12:35
@Saadnajmi
Copy link
Collaborator

Note: maybe the template app can have a swiftlint config file added to it? Out of scope of this repo though

@tido64 tido64 merged commit d6003bc into trunk May 5, 2025
30 checks passed
@tido64 tido64 deleted the tido/swiftlint-exclude-node-modules branch May 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants