Skip to content

feat: add :additional_build_settings to options #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

okwasniewski
Copy link
Contributor

Description

This change allows us to pass additional build settings to the main generated project:

options = {
  :app_build_settings => { 
    'LIBRARY_SEARCH_PATHS' => '$(inherited) "../something"',
  }
}


use_test_app! options 

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

Pass additional build setting.

@okwasniewski
Copy link
Contributor Author

Adding some test for this case would be great but I'm not sure how to test options passed to use_test_app, can you give me some clues how to test it? I couldn't find it in the repo

@tido64
Copy link
Member

tido64 commented Sep 2, 2024

Adding some test for this case would be great but I'm not sure how to test options passed to use_test_app, can you give me some clues how to test it? I couldn't find it in the repo

If we're talking about unit tests, we currently only test end-to-end. If we were to test this properly, I would extract the block where we populate build_settings to a separate function, and add tests for it. You can see examples of Ruby tests under /test.

@okwasniewski okwasniewski force-pushed the feat/additionalBuildSettings branch from 6054a04 to 1f4a83c Compare September 4, 2024 10:51
@okwasniewski okwasniewski force-pushed the feat/additionalBuildSettings branch from 1f4a83c to 23b3d7f Compare September 4, 2024 13:07
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@okwasniewski okwasniewski force-pushed the feat/additionalBuildSettings branch from aa9c1b7 to 3f908f7 Compare September 4, 2024 13:13
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this ❤️

@tido64 tido64 merged commit b04a565 into microsoft:trunk Sep 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants