-
Notifications
You must be signed in to change notification settings - Fork 92
feat: add :additional_build_settings to options #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add :additional_build_settings to options #2204
Conversation
Adding some test for this case would be great but I'm not sure how to test options passed to use_test_app, can you give me some clues how to test it? I couldn't find it in the repo |
If we're talking about unit tests, we currently only test end-to-end. If we were to test this properly, I would extract the block where we populate |
465c63a
to
6054a04
Compare
6054a04
to
1f4a83c
Compare
1f4a83c
to
23b3d7f
Compare
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
aa9c1b7
to
3f908f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this ❤️
Description
This change allows us to pass additional build settings to the main generated project:
Platforms affected
Test plan
Pass additional build setting.