-
Notifications
You must be signed in to change notification settings - Fork 94
Breaking changes in 3.0 #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes in 3.0 #1600
Conversation
8739748
to
32441df
Compare
1c5dfe6
to
ee1b1a2
Compare
884fcb6
to
09f11e0
Compare
60c163f
to
fe4ed70
Compare
cc1cd6e
to
c0c1bf7
Compare
update on my previous comment: it's all done, everything is working. BUT, to make it all work seamlessly, aside from Tommy's fix for the C++20 stuff, I had to do two minor bandaids local commits:
I think that ideally what we should do next is to go in main branch, address those things proper, then after merging there, revert my local bandaids and instead cherry pick the proper solution commits from main, and then we should be good to go with this. |
BREAKING CHANGE: Dropped support for Node 14
BREAKING CHANGE: Dropped support for `react-native` 0.64, 0.65
BREAKING CHANGE: Dropped support for Flipper For more context, see react-native-community/discussions-and-proposals#641.
BREAKING CHANGE: `react-native` 0.71 is now required for New Architecture
BREAKING CHANGE: Bumping C++ language standard to C++20 breaks React Native 0.65 and below.
one more round of testing before going ahead and merging. Testing 0.66 ✅A few finicky things:
Testing 0.70 ✅Notes:
![]() Testing 0.71 ✅Notes:
|
b2721bd
to
d35afd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did one more full round of testing, overall I think we are ready to go!
The only minor thing is that tweak to the options for the retryDelay but I'll send that over as a separate small PR.
Let's 🚢 this bad boy!
I also did a full round. It's strange that I never hit this |
Description
This PR collects all breaking changes for the upcoming 3.0 cut.
Resolves #1153.
Blocked by:
test-matrix.sh
to JS #1730react-native-macos
/-windows
0.73 #1752React-Fabric
build failure #1755Platforms affected
Test plan