Skip to content

fix(android): handle ReactApplication changes to getters - #1483

Merged
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/android-compatibility
Jul 4, 2023
Merged

fix(android): handle ReactApplication changes to getters#1483
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/android-compatibility

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Jul 4, 2023

Copy link
Copy Markdown
Member

Description

Signature changes were introduced in react/react-native@c3f672c.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

git apply scripts/disable-safe-area-context.patch
git apply scripts/android-nightly.patch
npm run set-react-version -- nightly
npm run clean
yarn
cd example/android
./gradlew clean assembleDebug

@github-actions github-actions Bot added the platform: Android This affects Android label Jul 4, 2023
@tido64
Tommy Nguyen (tido64) marked this pull request as ready for review July 4, 2023 11:36
@tido64
Tommy Nguyen (tido64) merged commit fafd197 into trunk Jul 4, 2023
@tido64
Tommy Nguyen (tido64) deleted the tido/android-compatibility branch July 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweggersen Sam Mathias Weggersen (sweggersen) sweggersen approved these changes
@kelset Lorenzo Sciandra (kelset) Awaiting requested review from kelset
@arazabishov Araz Abishov (arazabishov) Awaiting requested review from arazabishov

Assignees

No one assigned

Labels

platform: Android This affects Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @sweggersen