Skip to content

fix(android): fix Fabric cannot be enabled on 0.72 - #1389

Merged
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/android/venice-compat
Apr 13, 2023
Merged

fix(android): fix Fabric cannot be enabled on 0.72#1389
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/android/venice-compat

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Apr 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fix Fabric cannot be enabled on 0.72

Prerequisite for #1359.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version 0.72
yarn
cd example

# Set `newArchEnabled=true` in /example/gradle.properties

yarn android

@github-actions github-actions Bot added the platform: Android This affects Android label Apr 13, 2023
@tido64 Tommy Nguyen (tido64) mentioned this pull request Apr 13, 2023
Closed
8 tasks
@tido64
Tommy Nguyen (tido64) enabled auto-merge (squash) April 13, 2023 10:01
@tido64
Tommy Nguyen (tido64) merged commit fd1b266 into trunk Apr 13, 2023
@tido64
Tommy Nguyen (tido64) deleted the tido/android/venice-compat branch April 13, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arazabishov Araz Abishov (arazabishov) Awaiting requested review from arazabishov
@sweggersen Sam Mathias Weggersen (sweggersen) Awaiting requested review from sweggersen
1 more reviewer
@kelset Lorenzo Sciandra (kelset) kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: Android This affects Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @kelset