Skip to content

Conversation

acoates-ms
Copy link
Collaborator

Add logic to update the version number from 1000.0.0 to 0.0.0-canary. when running the internal publish build. -- This will then be changed to 0.0.0-canary.-microsoft.0 in a later build step.

Also removed some duplicated lines in the nuspec that was causing the nuget to not get created.

@acoates-ms acoates-ms requested a review from HeyImChris August 3, 2021 17:47
@acoates-ms acoates-ms requested a review from alloy as a code owner August 3, 2021 17:47
@pull-bot
Copy link

pull-bot commented Aug 3, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 7317d5e

inputs:
script: npm install

- task: CmdLine@2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to do this for Apple builds as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the react-native npm package contains built android binaries, its the android build that actually publishes the react-native package.

@acoates-ms acoates-ms merged commit 0184aef into microsoft:master Aug 3, 2021
@acoates-ms acoates-ms deleted the nightlymsver branch August 3, 2021 19:26
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants