Repository navigation
fix(macos): add no-op scroll indicator inset setters to RCTScrollView - #3130
Draft
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Draft
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Conversation
RCTScrollViewManager exports scrollIndicatorInsets, verticalScrollIndicatorInsets and automaticallyAdjustsScrollIndicatorInsets on every platform, but on macOS RCTScrollView has no setters for them, so setting one from JavaScript crashed. Add no-op setters on macOS. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ac4470-c1d2-43c0-92ee-8407909f0f6a
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTScrollViewManagerexportsscrollIndicatorInsets,verticalScrollIndicatorInsets, andautomaticallyAdjustsScrollIndicatorInsetson every platform, but on macOSRCTScrollViewhas no setters for them. Setting one from JavaScript crashed:RCTComponentDatagets a nil method signature for the twoUIEdgeInsetssetters, and sends an unrecognized selector for theBOOLone.This adds no-op setters for all three on macOS.
Office shipped the first two in its copy of React Native macOS 0.81.
automaticallyAdjustsScrollIndicatorInsetshas the same problem, so this covers it too.Test Plan:
Built the same change on 0.81 in Office for macOS arm64 and x86_64, with warnings as errors. CI covers
main.