ci(0.78): Add Hermes to test matrix #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary: I found that RNTester works with Hermes, so let's enable it in our CIs! This requires a bit of extra finagling to get the correct version. The implementation of `podspec_source_build_from_github_merge_base` shows how to do this. ## Test Plan: If CIs pass, we're good! --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
…icrosoft#2531) ## Summary: This is a follow-up to microsoft#2524 where we expect the RNCore version to be explicitly specified as a peer dependency in our stable branches. microsoft#2530 brings this in for 0.74-stable; this brings it into the main branch for cherry-picking into other branches. ## Test Plan: If CIs pass, we're good. This shouldn't do anything on the main branch anyway, since we don't run through any of the peer dependency logic. Either way, a quick run of RNTester validates that we're still getting our Hermes version via the same `git merge-base` approach. --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
## Summary: Discovered when cherry-picking microsoft#2531 into microsoft#2530. I didn't catch it before because we don't actually run through this part on the main branch. ## Test Plan: No effects on main branch, but microsoft#2530 CIs should succeed now. Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
Saadnajmi
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Based on #2524 and #2530.
Test Plan:
CI should pass