chore: use fallback resolver for new tags #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Mar 13, 2025
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 13, 2025
When demoting a stable branch, we need to create a new tag. Nx won't be able to find it on npm and should have a fallback. For all other branches, we don't want to use the fallback in case something fails. `main`: ``` ~/S/react-native-macos (main) % node .ado/scripts/prepublish-check.mjs --verbose ``` `0.76-stable`: ``` ~/S/react-native-macos (0.76-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 76 ℹ️ Expected npm tag: v0.76-stable ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'v0.76-stable' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be set to 'disk' ❌ Nx Release is not correctly configured for the current branch ``` `0.77-stable`: ``` ~/S/react-native-macos (0.77-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 77 ℹ️ Expected npm tag: latest ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ``` `0.78-stable`: ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ react-native-macos@next: 76 ℹ️ Expected npm tag: next ❌ 'defaultBase' must be set to '0.78-stable' ❌ 'release.version.generatorOptions.preid' must be set to 'rc' ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'next' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ```
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 13, 2025
## Summary: When demoting a stable branch, we need to create a new tag. Nx won't be able to find it on npm and should have a fallback. For all other branches, we don't want to use the fallback in case something fails. ## Test Plan: `main`: ``` ~/S/react-native-macos (main) % node .ado/scripts/prepublish-check.mjs --verbose ##vso[task.setvariable variable=publish_react_native_macos]1 ``` `0.76-stable`: ``` ~/S/react-native-macos (0.76-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 76 ℹ️ Expected npm tag: v0.76-stable ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'v0.76-stable' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be set to 'disk' ❌ Nx Release is not correctly configured for the current branch ``` `0.77-stable`: ``` ~/S/react-native-macos (0.77-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 77 ℹ️ Expected npm tag: latest ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ``` `0.78-stable`: ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ react-native-macos@next: 76 ℹ️ Expected npm tag: next ❌ 'defaultBase' must be set to '0.78-stable' ❌ 'release.version.generatorOptions.preid' must be set to 'rc' ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'next' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ```
Saadnajmi
added a commit
that referenced
this pull request
Mar 13, 2025
Backport #2414 to `0.77-stable` Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When demoting a stable branch, we need to create a new tag. Nx won't be able to find it on npm and should have a fallback. For all other branches, we don't want to use the fallback in case something fails.
Test Plan:
main:0.76-stable:0.77-stable:0.78-stable: