Fix responder chain in reactViewController on macOS #2380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I first noticed this while working on SwiftUI views for expo/expo#35078. Calling
reactViewController
on iOS always returns the correct view controller but on macOS, this same function will return nil for nested views.So this PR addresses the differences in responder chain behavior between iOS and macOS when aliasing UIViewController to NSViewController. On iOS, a view's nextResponder is naturally its own UIViewController, ensuring that helper functions like reactViewController work as expected. However, on macOS, an NSView's nextResponder does not include its NSViewController by default, which causes issues when trying to retrieve the view controller directly from the responder chain.
This change ensures that traversals will properly locate the NSViewController using the superview chain, mirroring iOS behavior.
Test Plan:
Run RNTester and we've been using this same function to render SwiftUI views on macOS in expo's repo