Fix the builds... #20

acoates-ms · 2019-03-24T05:08:07Z

Please select one of the following

I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Microsoft Reviewers: Open in CodeFlow

…native into readme

acoates-ms · 2019-03-25T04:04:43Z

/azp run

azure-pipelines · 2019-03-25T04:04:48Z

No pipelines are associated with this pull request.

acoates-ms · 2019-03-25T04:14:35Z

/azp run

azure-pipelines · 2019-03-25T04:14:40Z

No pipelines are associated with this pull request.

acoates-ms · 2019-03-25T21:44:36Z

/azp run

azure-pipelines · 2019-03-25T21:44:41Z

No pipelines are associated with this pull request.

HeyImChris · 2019-03-25T22:11:02Z

Libraries/Components/Picker/PickerIOS.macos.js

@@ -25,6 +25,19 @@ var processColor = require('processColor');
 var createReactClass = require('create-react-class');
 var requireNativeComponent = require('requireNativeComponent');

+import type {ColorValue} from 'StyleSheetTypes';


So changes to this file look like they're coming from fb's PickerIOS.ios.js. I'm not saying that's right/wrong for Mac, but are you purposefully keeping the mac version in parity with the iOS version? This doesn't look like what we have in sdx-platform is why I bring it up

commit 4c43e301d97042e9eec4401dd81b8ebce053f691 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:49:02 2019 -0700 Squashed commit of the following: commit 862f3fb5d9e3161feab6e5e0e61c7b28e8ac1ef9 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:37 2019 -0700 Revert "Merge 1b12e2c into 9f1e909" This reverts commit d036bc4, reversing changes made to 9f1e909. commit 41477c33c1bcc78f40da00ac7e86ab4dd3f7d062 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:23 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.1" This reverts commit 852df1a. commit 4993963205e737849e4880309ef86aeac9f2a765 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:16 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.2" This reverts commit 774513f. commit 41f8beadb2030593208ffc6ff29339991dde3798 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:07 2019 -0700 Revert "Merge 4f3c378 into 774513f" This reverts commit a840490, reversing changes made to 774513f. commit 143e70ec6228e110cd94a5ae9c56309040c1f1eb Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:45:57 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.3" This reverts commit 54dfee8. commit 138191b0d6bf9e4370fb5126dc2095a3fb122a57 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:45:16 2019 -0700 Revert "Merge d8be239 into 54dfee8" This reverts commit faae1e5, reversing changes made to 54dfee8. commit 40a77c8365c5273df0bba4fc2b0439db17d247d0 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:44 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.4" This reverts commit 043f633. commit adf5c26c8f7132a6643ecfea116226632173447b Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:42 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.5" This reverts commit 4004f88. commit e68d497a58e32d26f0d04130895954d7b654c2bf Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:39 2019 -0700 Revert "Fix the builds... (#20)" This reverts commit 745eeda. commit 4cdef1eef22edbcdc9ca86e31846a175b944999e Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:31 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.6" This reverts commit 34a3077.

Gets the circleci tests working again.

commit 4c43e301d97042e9eec4401dd81b8ebce053f691 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:49:02 2019 -0700 Squashed commit of the following: commit 862f3fb5d9e3161feab6e5e0e61c7b28e8ac1ef9 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:37 2019 -0700 Revert "Merge 1b12e2c into 9f1e909" This reverts commit d036bc4, reversing changes made to 9f1e909. commit 41477c33c1bcc78f40da00ac7e86ab4dd3f7d062 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:23 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.1" This reverts commit 852df1a. commit 4993963205e737849e4880309ef86aeac9f2a765 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:16 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.2" This reverts commit 774513f. commit 41f8beadb2030593208ffc6ff29339991dde3798 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:46:07 2019 -0700 Revert "Merge 4f3c378 into 774513f" This reverts commit a840490, reversing changes made to 774513f. commit 143e70ec6228e110cd94a5ae9c56309040c1f1eb Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:45:57 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.3" This reverts commit 54dfee8. commit 138191b0d6bf9e4370fb5126dc2095a3fb122a57 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:45:16 2019 -0700 Revert "Merge d8be239 into 54dfee8" This reverts commit faae1e5, reversing changes made to 54dfee8. commit 40a77c8365c5273df0bba4fc2b0439db17d247d0 Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:44 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.4" This reverts commit 043f633. commit adf5c26c8f7132a6643ecfea116226632173447b Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:42 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.5" This reverts commit 4004f88. commit e68d497a58e32d26f0d04130895954d7b654c2bf Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:39 2019 -0700 Revert "Fix the builds... (#20)" This reverts commit 745eeda. commit 4cdef1eef22edbcdc9ca86e31846a175b944999e Author: REDMOND\acoates <acoates@microsoft.com> Date: Tue Mar 26 10:34:31 2019 -0700 Revert "Applying package update to 0.58.6-microsoft.6" This reverts commit 34a3077.

…tion for existing view (facebook#51294) Summary: Pull Request resolved: facebook#51294 changelog: [internal] Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated. The differentiator would generate a create instruction for a view that already exists. Stack trace for the crash: ``` * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT * frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264 frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100 frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128 frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296 frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124 frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468 frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12 frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32 frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88 frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384 frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268 frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528 frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356 frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80 frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40 frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40 frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44 frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44 frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10 frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3 frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544 frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456 frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308 frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40 frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24 frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12 frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24 frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184 frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40 frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920 frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536 frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164 frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796 frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124 frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200 frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20 frame microsoft#39: 0x0000000111506b4c dyld`start + 6000 ``` Reviewed By: rubennorte Differential Revision: D74654157 fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386

acoates-ms added 4 commits March 23, 2019 21:51

more flow fixes

95f168b

Put back readme header

dfba2e8

Merge branch 'facebook58merge' of https://github.com/Microsoft/react-…

bc0e137

…native into readme

Flow fixes

0286b6b

Hopefully last flow error

127a7e5

acoates-ms and others added 2 commits March 24, 2019 21:54

Some android flow fixes

77d9f1d

More flow fixes

f573ce5

acoates-ms changed the title ~~Put back readme header~~ Fix the builds... Mar 25, 2019

HeyImChris reviewed Mar 25, 2019

View reviewed changes

HeyImChris approved these changes Mar 25, 2019

View reviewed changes

acoates-ms merged commit 745eeda into microsoft:master Mar 25, 2019

acoates-ms deleted the readme branch March 25, 2019 22:17

t-nanava pushed a commit that referenced this pull request Jun 17, 2019

Fix the builds... (#20)

5b12dc9

Gets the circleci tests working again.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix the builds... #20

Fix the builds... #20

Uh oh!

acoates-ms commented Mar 24, 2019 •

edited

Loading

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

HeyImChris Mar 25, 2019

Uh oh!

Uh oh!

Fix the builds... #20

Fix the builds... #20

Uh oh!

Conversation

acoates-ms commented Mar 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please select one of the following

Microsoft Reviewers: Open in CodeFlow

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

acoates-ms commented Mar 25, 2019

Uh oh!

azure-pipelines bot commented Mar 25, 2019

Uh oh!

HeyImChris Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

acoates-ms commented Mar 24, 2019 •

edited

Loading