Skip to content

[0.68-stable] A couple of renames to make Dynamic Type features more proper #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

[0.68-stable] A couple of renames to make Dynamic Type features more proper #1453

merged 2 commits into from
Oct 17, 2022

Conversation

amgleitman
Copy link
Member

A couple of renames for the new Dynamic Type feature:

  • subhead -> subheadline. Apple's typography page lists the subheadline type as the abbreviated "Subhead," but Apple's official APIs prefer the full name "subheadline" as per these three examples, so we should probably stick with those.
  • RCTUIBaseSizeForDynamicTypeRamp -> RCTBaseSizeForDynamicTypeRamp. The UI prefix shouldn't be here since we're not referring to a UIKit type.

@amgleitman amgleitman requested a review from a team as a code owner October 17, 2022 22:17
@amgleitman amgleitman mentioned this pull request Oct 17, 2022
Merged
@amgleitman amgleitman enabled auto-merge October 17, 2022 22:34
@amgleitman amgleitman merged commit a33466c into microsoft:0.68-stable Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lyzhan7 lyzhan7 lyzhan7 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amgleitman @lyzhan7