Skip to content

Fix ifdef for shadow inconsistency bug fix #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix ifdef for shadow inconsistency bug fix #1378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baba2c9
Fix ifdef
lyzhan7 Aug 25, 2022
c199354
Merge branch 'main' into lyzhan-fix-ifdef
lyzhan7 Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion React/Views/RCTViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ - (RCTShadowView *)shadowView
RCT_REMAP_VIEW_PROPERTY(opacity, alphaValue, CGFloat)
#endif // ]TODO(macOS GH#774)

#if TARGET_OS_OSX // TODO(macOS GH#774)
#if !TARGET_OS_OSX // TODO(macOS GH#774)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this work before? and nothing failed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had the same question, I didn't test on IOS when I made this change but I feel like I should have seen errors when I tested on macOS

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a copy-paste error since you tested in FURN and not RN-Tester?

RCT_REMAP_VIEW_PROPERTY(shadowColor, layer.shadowColor, CGColor)
RCT_REMAP_VIEW_PROPERTY(shadowOffset, layer.shadowOffset, CGSize)
RCT_REMAP_VIEW_PROPERTY(shadowOpacity, layer.shadowOpacity, float)
Expand Down