-
Notifications
You must be signed in to change notification settings - Fork 49
Bump gallery to RNW .72 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this file being deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added by the move from fabricbot to the new bot infrastructure. It contains the logic the bot uses for applying triage labels and such. It shouldn't be affected by any code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaningful change in this patch is small. Like one line, updating the min version. But there's a ton of extra content in the patch file. I've hit this too, and as far as I can tell it's getting some of the generated code in the patch file, which isn't quite right. I've started manually editing the patch files to make sure they stay minimal, although it's a bit of a pain. I've also had lunch making the code change, running patch package before I build, and then it's only the code changes I expect and not the generated files too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call out! Didn't realize how large those files were, changed them to only include the small file change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Bumps Gallery to RNW .72
What
Due to inactive Community Modules, we had to patch the following CMS to the right WindowsTargetPlatformMinVersion. We
can remove the patches when they take in the changes listed here (#324) and publish a new version.
Created follow up issue to deal with Flyout and Popout jest tests: #344