Prevent Rollback crash when binary was updated. #924
Conversation
|
@AndrewJack, |
|
@AndrewJack Great stuff and thanks for taking care of this. Looks good to me. |
| String binaryModifiedDateDuringPackageInstallString = packageMetadata.optString(CodePushConstants.BINARY_MODIFIED_TIME_KEY, null); | ||
| if (binaryModifiedDateDuringPackageInstallString != null) { | ||
| binaryModifiedDateDuringPackageInstall = Long.parseLong(binaryModifiedDateDuringPackageInstallString); | ||
| } |
There was a problem hiding this comment.
Ah just spotted this - The NumberFormatException should be caught
There was a problem hiding this comment.
Aye, good note, and it can be moved away from getJSBundleFileInternal method probably
| if (!isPackageBundleLatest(packageMetadata) && hasBinaryVersionChanged(packageMetadata)) { | ||
| CodePushUtils.log("Skipping initializeUpdateAfterRestart(), binary version is newer"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should I move this inside if (pendingUpdate != null) { to avoid reading the file getCurrentPackage file every time.
|
Hi @AndrewJack, thank you for the contribution, looks good to me. |
4 participants
Fixes: #921
Senario:
When a code push update failed (rollback on next start), but the binary version was updated before the next restart.
This causes a the initialisation code to start a rollback, and clear the previous update at the same time causing IO crashes due to the unexpected state (deleted
/CodePushdirectory).Easier to reproduce with
InstallMode.ON_NEXT_RESTART