Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@newyankeecodeshop
Copy link
Contributor

The _installMode property should not be declared as a pointer since it holds an enum value. This code causes Xcode to display the following warnings:

Showing All Issues
.../node_modules/react-native-code-push/ios/CodePush/CodePush.m:591:22: Comparison between pointer and integer ('CodePushInstallMode *' (aka 'enum CodePushInstallMode *') and 'NSInteger' (aka 'long'))
.../node_modules/react-native-code-push/ios/CodePush/CodePush.m:775:22: Incompatible integer to pointer conversion assigning to 'CodePushInstallMode *' (aka 'enum CodePushInstallMode *') from 'CodePushInstallMode' (aka 'enum CodePushInstallMode'); take the address with &

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@max-mironov
Copy link
Contributor

@newyankeecodeshop good catch and thanks for contribution! Merging this.

@max-mironov max-mironov merged commit 26d84b5 into microsoft:master Jul 17, 2017
@newyankeecodeshop newyankeecodeshop deleted the fix-warning branch July 17, 2017 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants