Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

[WPF] Fix application crash when storage file was deleted while app is being active. #897

Merged
sergey-akhalkov merged 2 commits into from Jun 22, 2017
Merged

[WPF] Fix application crash when storage file was deleted while app is being active. #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7f176
Create file if non exist on each call
abodalevsky Jun 21, 2017
a7029bf
Added asyn operation
abodalevsky Jun 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Examples/CodePushDemoApp/windows/CodePushDemoApp/CodePushDemoApp.nuget.targets
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions windows/CodePush.Net46/Adapters/Storage/ApplicationDataContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,12 @@ public class ApplicationDataContainer
private readonly SemaphoreSlim mutex = new SemaphoreSlim(1, 1);

const string STORAGE_NAME = "AppStorage.data";
IFile storageFile = null;
string storageFileName = null;

public ApplicationDataContainer(string name = STORAGE_NAME)
{
storageFile = FileSystem.Current.LocalStorage.CreateFileAsync(name, CreationCollisionOption.OpenIfExists).Result;
storageFileName = name;
var storageFile = FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).Result;
var data = CodePushUtils.GetJObjectFromFileAsync(storageFile).Result;

if (data != null)
Expand All @@ -90,14 +91,16 @@ async Task SaveAsync()
{
await mutex.WaitAsync().ConfigureAwait(false);
var jobject = JObject.FromObject(Values);
var storageFile = await FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).ConfigureAwait(false);
await storageFile.WriteAllTextAsync(JsonConvert.SerializeObject(jobject)).ConfigureAwait(false);
mutex.Release();
}

public async Task DeleteAsync()
{
Values.Clear();
await storageFile.DeleteAsync();
var storageFile = await FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).ConfigureAwait(false);
await storageFile.DeleteAsync().ConfigureAwait(false);
}
}
}