Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Fix return value for get update metadata #864

Merged
sergey-akhalkov merged 3 commits into from
Jun 1, 2017
Merged

Fix return value for get update metadata #864

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23808ca
Fixed issue with error on parsing plist path
May 17, 2017
dec9398
Merge branch 'master' of https://github.com/Microsoft/react-native-co…
May 26, 2017
04439b6
Changed return value to null for getUpdateMetadata instead of empty s…
May 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ protected Void doInBackground(Void... params) {
JSONObject currentPackage = mUpdateManager.getCurrentPackage();

if (currentPackage == null) {
promise.resolve("");
promise.resolve(null);
return null;
}

Expand All @@ -333,14 +333,14 @@ protected Void doInBackground(Void... params) {
if (updateState == CodePushUpdateState.PENDING.getValue() && !currentUpdateIsPending) {
// The caller wanted a pending update
// but there isn't currently one.
promise.resolve("");
promise.resolve(null);
} else if (updateState == CodePushUpdateState.RUNNING.getValue() && currentUpdateIsPending) {
// The caller wants the running update, but the current
// one is pending, so we need to grab the previous.
JSONObject previousPackage = mUpdateManager.getPreviousPackage();

if (previousPackage == null) {
promise.resolve("");
promise.resolve(null);
return null;
}

Expand Down