-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove support for legacy React Native versions #845
Remove support for legacy React Native versions #845
Conversation
|
@AndrewJack, It will cover your contributions to all Microsoft-managed open source projects. |
|
@AndrewJack, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any issue with clearing this before we attempt to load the bundle? We don't need the callback after this point.
We must call this before loadBundleLegacy() or it will go into an infinite restart loop.
|
@sergey-akhalkov any chance of this being reviewed/ merged soon? |
|
@AndrewJack - thanks for great contribution. I believe we should test it very careful before merging this changes. |
|
@max-mironov I've had a look through your changes. I'll rebase my PR once yours has been merged. |
|
@max-mironov I've rebased after your changes were merged. |
|
Hello @AndrewJack. Your changes looks good and reasonable to me! I've double checked all main cases (with different installModes) on emulator and on real device with signed apk (Android7) and haven't found any issues. We really appreciate your efforts and help here - thank you for this! I'm good with merging this stuff but probably @sergey-akhalkov could also have a look at this before we incorporate this changes to Master. |
Fixes: #841
v2 of code push only supports RN 0.43 and later. This means we no longer need to use reflection for backward compatibility.