Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

daniel-beard
Copy link
Contributor

@msftclas
Copy link

Hi @daniel-beard, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@geof90
Copy link
Contributor

geof90 commented Aug 25, 2016

@daniel-beard Can you share how you are using these methods from native code, that they would need to be exposed publicly? It is true that they are exposed in Android but they are also completely undocumented, and it would be great if we have a good reason for supporting them going forward.

@daniel-beard
Copy link
Contributor Author

I'm creating a dev settings screen for QA that shows the current status of CodePush which shows the current status of CodePush (including whether it has a failed or pending update)

@geof90
Copy link
Contributor

geof90 commented Aug 25, 2016

I see. Is there a reason why you can't get this information from JS?

@daniel-beard
Copy link
Contributor Author

I'm calling this from native, so I'd rather avoid the round trip from iOS -> JS -> iOS

@geof90 geof90 merged commit 1447ffb into microsoft:master Aug 25, 2016
@geof90
Copy link
Contributor

geof90 commented Aug 25, 2016

I'll go ahead and merge this, the changes look clean. Thanks @daniel-beard!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants