This repository was archived by the owner on May 20, 2025. It is now read-only.
[Bug] Fix iOS rollback recording #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandergoncharov-zz
approved these changes
Mar 13, 2020
pfleidi
approved these changes
Mar 13, 2020
Member
pfleidi
left a comment
pfleidi
left a comment
There was a problem hiding this comment.
This is a surprisingly small fix. Great work ✨
sourabhdebnath
pushed a commit
to scripbox/react-native-code-push
that referenced
this pull request
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We found that react-native-code-push on iOS does not record rollbacks when broken bundles are pushed. The reason was that the
setLatestRollbackInfofunction would not resolve the promise.Solution: Add promise resolve to
setLatestRollbackInfofunction.