Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@max-mironov
Copy link
Contributor

@max-mironov max-mironov commented Jan 21, 2018

Intent: As of now the latest versions of React Native have the following logic to export the class by default:

export default class App extends Component<{}> {}

This will not work in some cases for CodePush as we need to export the class after we've codepushified the app (#1147)
So added explicit export examples for docs to make the intentions clear.

@Zakeelm probably we also need to update docs here: https://docs.microsoft.com/en-us/appcenter/distribution/codepush/react-native

@max-mironov max-mironov changed the title Improve readme Improve README of integration of CodePush Jan 21, 2018
Copy link
Contributor

@sergey-akhalkov sergey-akhalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-mironov max-mironov merged commit d6cf63e into microsoft:master Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants