This repository was archived by the owner on May 20, 2025. It is now read-only.
[docs] Add information about how to configure CodePush for applications using ReactInstanceManager.builder() to initialize RN #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information about how to configure CodePush for applications using ReactInstanceManager.builder() to initialize RN
max-mironov
reviewed
Dec 5, 2017
docs/setup-android.md
Outdated
| @@ -107,6 +109,40 @@ protected String getJSMainModuleName() { | |||
| } | |||
| ``` | |||
|
|
|||
| If you are integrating React Native into existing application please do the following: | |||
|
|
|||
| Update `MyReactActivity.java` (it could be named differently in you app) file to use CodePush via the following changes: | |||
There was a problem hiding this comment.
nit: mistype, differently in your app
docs/setup-android.md
Outdated
| @@ -66,6 +66,8 @@ After installing the plugin and syncing your Android Studio project with Gradle, | |||
|
|
|||
| **For React Native >= v0.29** | |||
|
|
|||
| If you are using React Native for the whole application please do the following: | |||
There was a problem hiding this comment.
Not sure if the word whole application fits good here. Probably we could rephrase like If you are integrating Code Push into React Native application please do the following steps:
docs/setup-android.md
Outdated
| @@ -107,6 +109,40 @@ protected String getJSMainModuleName() { | |||
| } | |||
| ``` | |||
|
|
|||
| If you are integrating React Native into existing application please do the following: | |||
There was a problem hiding this comment.
I'd prefer to say here If you are integrating React Native into existing native application please do the following steps:
max-mironov
approved these changes
Dec 6, 2017
sergey-akhalkov
approved these changes
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RN beginners who is coming from here couldn't find information how to configure CodePush for existing android apps. This PR intends to fix this.
Also this PR relates to #970 (comment)