Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@sergey-akhalkov
Copy link
Contributor

@sergey-akhalkov sergey-akhalkov commented Sep 18, 2017

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to keep logging here to help devs to debug going further?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

Copy link
Contributor

@ruslan-bikkinin ruslan-bikkinin Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add exception logging here to be able determine cause of problem in future:

CodePushUtils.log(ex.getMessage());
CodePushUtils.log(ex.getStackTrace().toString());

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants