This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix dex index overflow exception #1007
Merged
ruslan-bikkinin
merged 6 commits into
microsoft:master
from
sergey-akhalkov:fix_DexIndexOverflowException
Sep 18, 2017
Merged
Fix dex index overflow exception #1007
ruslan-bikkinin
merged 6 commits into
microsoft:master
from
sergey-akhalkov:fix_DexIndexOverflowException
Sep 18, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-mironov
reviewed
Sep 18, 2017
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep logging here to help devs to debug going further?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks!
ruslan-bikkinin
suggested changes
Sep 18, 2017
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add exception logging here to be able determine cause of problem in future:
CodePushUtils.log(ex.getMessage());
CodePushUtils.log(ex.getStackTrace().toString());…jwt #1002 use another lib - nimbus-jose-jwt
ruslan-bikkinin
approved these changes
Sep 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1002