CodePushDeploymentKey react-native link bug when using firebase

[Yox2l]

• react-native-code-push version: 1.16.1-beta
• react-native version: 0.39.2

I'm using firebase in my react-native app and therefore I have a GoogleService-Info.plist in my project now when I run the "react-native link" command the CodePushDeploymentKey added to GoogleService-Info.plist instead of the Info.plist file.

[axemclion]

Looks like it is due to this line - https://github.com/Microsoft/react-native-code-push/blob/master/scripts/postlink/ios/postlink.js#L52

We need to look for Info.plist, not *Info.plist.

cc @vladimir-kotikov

[vladimir-kotikov]

Yeah, changing the glob's pattern is the simplest approach, but we were thinking about more advanced one - reading path to/name of *.plist from xcode project rather than globbing it by pattern.

[max-mironov]

Closed it for now as a pull request with fixes has been already merged.

[jordanmkoncz]

@max-mironov Has this fix made it into a release yet? I've just followed the CodePush setup instructions from scratch, with "react-native-code-push": "^1.17.3-beta" being installed, and I had this same issue happen.

[max-mironov]

@jordanmkoncz hello - yes, that fix should be present in recent 1.17.3 beta version.
If you still see the issue is it possible for you to open another ticket and fill as much details as possible here and we will look at?

[jordanmkoncz]

@max-mironov Done :)