-
Notifications
You must be signed in to change notification settings - Fork 121
Remove w/=
and w/
operations in our repo's Q# code
#2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change in memory usage detected by benchmark. Memory Report for 099fcb2
|
Of note with this one, we have a bit of a timing challenge: we should merge after the release with the feature goes out since the samples are treated as a live resource BUT we must merge before the release with the feature goes out so that the embedded samples have the new syntax. I think this means we have to hit that window of merging just before we know we are going to do an official release. |
Change in memory usage detected by benchmark. Memory Report for 0f3ab13
|
Change in memory usage detected by benchmark. Memory Report for 78198ee
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample also shows the copy and update syntax for structs. Is this intentionally deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have two new samples to replace this file: one for the copy syntax of structs and a separate one for the array index assignment.
@swernli why, what do you have in mind when you say "live resource"? Do we have direct links to the |
Yeah, last I checked we do. We still get referrals from learn.microsoft.com and quantum.microsoft.com, and I believe the learn site still deep links to the samples folder. It's possible those links have changed since I last looked though. |
We need to also consider that QCOM takes new packages and updates katas and samples regularly from them, but doesn't always update the engine/compiler when they take a new drop, so we'll need to coordinate with them to ensure we dont check in unless they'll be updating content and the compiler. |
Updates the Katas, Libraries, and Samples to remove
w/=
andw/
. Copilot instruction file is also updated to instruct the copilot to avoid using these operators.