Skip to content

Remove w/= and w/ operations in our repo's Q# code #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ScottCarda-MS
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS commented May 16, 2025

Updates the Katas, Libraries, and Samples to remove w/= and w/. Copilot instruction file is also updated to instruct the copilot to avoid using these operators.

@ScottCarda-MS ScottCarda-MS marked this pull request as ready for review May 16, 2025 22:11
Copy link

Change in memory usage detected by benchmark.

Memory Report for 099fcb2

Test This Branch On Main Difference
compile core + standard lib 25228490 bytes 25218942 bytes 9548 bytes

@swernli
Copy link
Collaborator

swernli commented May 16, 2025

Of note with this one, we have a bit of a timing challenge: we should merge after the release with the feature goes out since the samples are treated as a live resource BUT we must merge before the release with the feature goes out so that the embedded samples have the new syntax. I think this means we have to hit that window of merging just before we know we are going to do an official release.

@ScottCarda-MS ScottCarda-MS requested a review from idavis as a code owner May 16, 2025 23:05
Copy link

Change in memory usage detected by benchmark.

Memory Report for 0f3ab13

Test This Branch On Main Difference
compile core + standard lib 25228490 bytes 25218942 bytes 9548 bytes

Copy link

Change in memory usage detected by benchmark.

Memory Report for 78198ee

Test This Branch On Main Difference
compile core + standard lib 25228490 bytes 25218942 bytes 9548 bytes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample also shows the copy and update syntax for structs. Is this intentionally deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have two new samples to replace this file: one for the copy syntax of structs and a separate one for the array index assignment.

@minestarks
Copy link
Member

@swernli why, what do you have in mind when you say "live resource"? Do we have direct links to the main of this repo from documentation?

@swernli
Copy link
Collaborator

swernli commented May 16, 2025

@swernli why, what do you have in mind when you say "live resource"? Do we have direct links to the main of this repo from documentation?

Yeah, last I checked we do. We still get referrals from learn.microsoft.com and quantum.microsoft.com, and I believe the learn site still deep links to the samples folder. It's possible those links have changed since I last looked though.

@billti
Copy link
Member

billti commented May 19, 2025

We need to also consider that QCOM takes new packages and updates katas and samples regularly from them, but doesn't always update the engine/compiler when they take a new drop, so we'll need to coordinate with them to ensure we dont check in unless they'll be updating content and the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants