Add explicit cast support #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryVasilevsky
approved these changes
May 8, 2025
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_angle.rs
Outdated
Show resolved
Hide resolved
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_angle.rs
Outdated
Show resolved
Hide resolved
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/tests/expression/explicit_cast_from_angle.rs
Outdated
Show resolved
Hide resolved
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/tests/expression/implicit_cast_from_bit.rs
Outdated
Show resolved
Hide resolved
idavis
reviewed
May 8, 2025
idavis
reviewed
May 8, 2025
idavis
reviewed
May 8, 2025
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_float.rs
Outdated
Show resolved
Hide resolved
idavis
reviewed
May 8, 2025
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_float.rs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_bit.rs
Dismissed
Show dismissed
Hide dismissed
compiler/qsc_qasm/src/semantic/tests/expression/explicit_cast_from_bit.rs
Dismissed
Show dismissed
Hide dismissed
idavis
force-pushed
the
oscarpuente/explicit-cast
branch
from
4514044 to
7db623c
Compare
idavis
force-pushed
the
oscarpuente/explicit-cast
branch
from
7db623c to
b467812
Compare
|
Change in memory usage detected by benchmark. Memory Report for b350269
|
|
Change in memory usage detected by benchmark. Memory Report for f69e465
|
|
Change in memory usage detected by benchmark. Memory Report for 727aa46
|
idavis
approved these changes
May 15, 2025
|
Change in memory usage detected by benchmark. Memory Report for 9ba0d7c
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit cast support and fixes a few issues with implicit casting as a side effect.