Swap Control and Target #2311
Merged
Swap Control and Target #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
billti,
DmitryVasilevsky and
minestarks
as code owners
21 tasks
|
I'm not sure that moving control to a different line should add another control (your second example). This seems a bit counterintuitive. We should probably discuss it, but the change can go in if needed. |
DmitryVasilevsky
approved these changes
Apr 21, 2025
This is specifically the copy-move with holding down the ctrl key. This copy-moves other gates as well. Regular moving a control will not copy the control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In circuit editing, when moving a control onto a target or vise-versa, the control and target should swap positions.
This also fixes an issue with copy-moving controls. The behavior is now that it will create a new control for the same operation and possibly move the operation horizontally in the circuit.