Fix Test Explorer issues #2291
Merged
Fix Test Explorer issues #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
approved these changes
Apr 11, 2025
idavis
approved these changes
Apr 11, 2025
|
Note: related to #944 |
billti
commented
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues.
Firstly, Q# code used in chat contexts was showing up in the Test Explorer as additional documents (and possibly other locations). It seems to use a few schemes all starting with 'chat', so excluding those.
Secondly, the location given for failing tests was often wrong, and falling back to the first 'related' location span when we're also using that for the document uri anyway resolves that issue. (And seems like the correct thing to do anyway).