-
Notifications
You must be signed in to change notification settings - Fork 122
Fix run button disable. Switching to tutorial and back to samples (#1849) #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I saw that this workaround is not good, because there are same kata into different editor. I will work on it. |
I understood. From Monaco doc: Each model is identified by a URI. This is why it's not possible for two models to have the same URI. Currently, we don't have the IDs for |
After several tests, I noticed a side effect when using updateDocument. Then the file is not closed with closeDocument. This should solve the problem. I think independent uri are therefore not necessary, or they would be an NTH. |
Sorry @thecoder93 , you caught us at a particularly busy time - just now getting to look at this fix. The code change looks reasonable but I don't immediately see the connection to #1849. Testing. |
No problem @minestarks |
Indeed I can repro the bug and this seems to fix it. Good catch @thecoder93 and thank you! |
Hi, This should fix the problem #1849
I think that the first time the model is created and then the get is done. For
samples
kataSection isundefined
and I don't know why the EntryPoint is missing. What do you think? Probably it's only a workaround.