Avoid errors in read-only GitHub sources #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an incremental improvement for viewing GitHub sources that avoids treating them as open documents since they are read-only buffers. In the future, we can do the work to associate them with the existing compilation taht contains those sources so that things like hover and goto-def work, but for now those code paths are user-code specific and need some reworking to handle navigation in a compile unit for a dependency.
swernli
requested review from
billti,
idavis,
minestarks,
ScottCarda-MS and
sezna
as code owners
Benchmark for 4259743Click to view benchmark
|
billti
reviewed
Jul 25, 2024
Benchmark for c50af84Click to view benchmark
|
billti
approved these changes
Jul 26, 2024
sezna
approved these changes
Jul 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…with a real project (#2139) Small fix to #1787 while staying true to the intention of that change. We want to _hide_ errors from GitHub sources that are open in the editor, but aren't associated with a project. They're essentially orphans. For example, you may have closed the original project that referenced those GitHub sources, but left the GitHub source open in the editor. But we want to _show_ errors from GitHub sources if they're part of a normal project. Errors from dependencies are helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental improvement for viewing GitHub sources that avoids treating them as open documents since they are read-only buffers. In the future, we can do the work to associate them with the existing compilation taht contains those sources so that things like hover and goto-def work, but for now those code paths are user-code specific and need some reworking to handle navigation in a compile unit for a dependency.